Skip to content

Conversation

@jaidisido
Copy link
Contributor

Issue #, if available:
#576

Description of changes:

  • Added optional ctas_database_name argument to store ctas_temporary_table in an alternative database (i.e. not the context database)
  • This alternative database must exist and won't be created
  • Added additional test in test_athena_ctas

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jaidisido jaidisido added enhancement New feature or request major release Will be addressed in the next major release labels Mar 11, 2021
@jaidisido jaidisido added this to the 2.6.0 milestone Mar 11, 2021
@jaidisido jaidisido requested a review from igorborgest March 11, 2021 15:50
@jaidisido jaidisido self-assigned this Mar 11, 2021
Copy link
Contributor

@igorborgest igorborgest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

return "aws_data_wrangler_external"


@pytest.fixture(scope="function")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@jaidisido jaidisido merged commit 14b240c into main Mar 12, 2021
@jaidisido jaidisido deleted the enhancement/ctas_temp_database branch March 12, 2021 11:12
@jaidisido jaidisido added minor release Will be addressed in the next minor release and removed major release Will be addressed in the next major release labels Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request minor release Will be addressed in the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Be able to configure ctas temporary database name in athena.read_sql_query

2 participants